-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): support value meta in hash agg #1860
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 70.81% 70.91% +0.10%
==========================================
Files 607 610 +3
Lines 79593 79685 +92
==========================================
+ Hits 56363 56509 +146
+ Misses 23230 23176 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
/// Consistent hash value to be set in value meta. Used for grouping the kv together in | ||
/// storage. Each state will have the same consistent hash value. | ||
consistent_hash_value: u16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may propose some shorter name for consistent_hash_value
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. What about place_key
?
What's changed and what's your intention?
Please explain IN DETAIL what the changes are in this PR and why they are needed:
HashCode
struct to bypass async closure problem.Checklist