Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): use row iterator of StreamChunk in top-n #1869

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

What's changed and what's your intention?

As title. So that there's no need to compact the stream chunk.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao enabled auto-merge (squash) April 15, 2022 07:04
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1869 (41fd07e) into main (37ae902) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   70.89%   70.86%   -0.03%     
==========================================
  Files         611      611              
  Lines       79623    79595      -28     
==========================================
- Hits        56447    56408      -39     
- Misses      23176    23187      +11     
Flag Coverage Δ
rust 70.86% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/stream_chunk_iter.rs 98.78% <100.00%> (+5.10%) ⬆️
src/stream/src/executor_v2/hop_window.rs 80.55% <100.00%> (-1.03%) ⬇️
src/stream/src/executor_v2/top_n.rs 90.56% <100.00%> (-0.08%) ⬇️
src/stream/src/executor_v2/top_n_appendonly.rs 93.32% <100.00%> (+0.57%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 46.66% <0.00%> (-5.34%) ⬇️
src/storage/src/hummock/local_version_manager.rs 81.75% <0.00%> (-4.73%) ⬇️
src/common/src/array/data_chunk_iter.rs 84.29% <0.00%> (-1.58%) ⬇️
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.16% <0.00%> (+0.26%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao merged commit 45b65da into main Apr 15, 2022
@BugenZhao BugenZhao deleted the bz/refactor-top-n-with-stream-chunk-row-iter branch April 15, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants