Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): support multiple dispatchers on compute node #1879

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 15, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #865
ref #719

src/stream/src/executor/dispatch.rs Outdated Show resolved Hide resolved
src/stream/src/executor/dispatch.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1879 (bdaaceb) into main (f3f296a) will increase coverage by 0.01%.
The diff coverage is 29.03%.

@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   70.60%   70.61%   +0.01%     
==========================================
  Files         611      611              
  Lines       79958    79957       -1     
==========================================
+ Hits        56451    56459       +8     
+ Misses      23507    23498       -9     
Flag Coverage Δ
rust 70.61% <29.03%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/task/stream_manager.rs 0.00% <0.00%> (ø)
src/stream/src/executor/dispatch.rs 76.31% <78.94%> (-0.17%) ⬇️
src/stream/src/executor/integration_tests.rs 95.75% <100.00%> (+0.05%) ⬆️
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh force-pushed the skyzh/multi-dispatcher-compute branch from ba1ccdb to bdaaceb Compare April 18, 2022 03:22
@skyzh skyzh requested a review from BugenZhao April 18, 2022 03:22
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh skyzh merged commit 7fbaafc into main Apr 18, 2022
@skyzh skyzh deleted the skyzh/multi-dispatcher-compute branch April 18, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streaming: support multiple dispatcher per actor
2 participants