Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): move agg mod to executor v2 #1885

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

pleiadesian
Copy link
Contributor

What's changed and what's your intention?

As title. Also, AggExecutorWrapper is moved into agg mod.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #1885 (7e06634) into main (ebdb341) will increase coverage by 0.01%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
+ Coverage   70.70%   70.72%   +0.01%     
==========================================
  Files         611      610       -1     
  Lines       79861    79844      -17     
==========================================
+ Hits        56465    56466       +1     
+ Misses      23396    23378      -18     
Flag Coverage Δ
rust 70.72% <96.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/global_simple_agg.rs 0.00% <ø> (ø)
src/stream/src/executor/hash_agg.rs 0.00% <ø> (ø)
src/stream/src/executor/integration_tests.rs 95.70% <ø> (ø)
src/stream/src/executor/local_simple_agg.rs 0.00% <ø> (ø)
.../src/executor/managed_state/aggregation/extreme.rs 90.00% <ø> (-0.27%) ⬇️
...ream/src/executor/managed_state/aggregation/mod.rs 79.45% <ø> (ø)
...am/src/executor/managed_state/aggregation/value.rs 96.42% <ø> (ø)
src/stream/src/executor/mod.rs 51.51% <ø> (ø)
src/stream/src/executor_v2/aggregation/agg_call.rs 87.50% <ø> (ø)
src/stream/src/executor_v2/aggregation/foldable.rs 88.10% <ø> (ø)
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pleiadesian pleiadesian marked this pull request as ready for review April 16, 2022 07:08
@pleiadesian pleiadesian enabled auto-merge (squash) April 16, 2022 07:08
Signed-off-by: Zulai Wang <zl31wang@gmail.com>
@pleiadesian pleiadesian merged commit ecbd5a5 into main Apr 16, 2022
@pleiadesian pleiadesian deleted the wzl/refactor-agg-mod branch April 16, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants