Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): implement GlobalSimpleAgg without AggExecutor #1887

Merged
merged 5 commits into from
Apr 16, 2022

Conversation

pleiadesian
Copy link
Contributor

Signed-off-by: Zulai Wang zl31wang@gmail.com

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#1886

Signed-off-by: Zulai Wang <zl31wang@gmail.com>
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #1887 (f023542) into main (ecbd5a5) will decrease coverage by 0.01%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
- Coverage   70.71%   70.70%   -0.02%     
==========================================
  Files         610      610              
  Lines       79844    79832      -12     
==========================================
- Hits        56465    56446      -19     
- Misses      23379    23386       +7     
Flag Coverage Δ
rust 70.70% <98.03%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/global_simple_agg.rs 96.91% <98.03%> (-0.16%) ⬇️
...stream/src/executor_v2/aggregation/agg_executor.rs 85.39% <0.00%> (-5.06%) ⬇️
src/meta/src/manager/epoch.rs 83.01% <0.00%> (+3.77%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI failed

@pleiadesian pleiadesian enabled auto-merge (squash) April 16, 2022 10:37
@pleiadesian pleiadesian merged commit 5eb35c0 into main Apr 16, 2022
@pleiadesian pleiadesian deleted the wzl/global-simple-agg-no-wrapper branch April 16, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants