Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): split chunks in hash agg #1890

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

pleiadesian
Copy link
Contributor

@pleiadesian pleiadesian commented Apr 16, 2022

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#1891

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #1890 (daace41) into main (470a18a) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
- Coverage   70.92%   70.91%   -0.02%     
==========================================
  Files         619      619              
  Lines       80106    80049      -57     
==========================================
- Hits        56816    56763      -53     
+ Misses      23290    23286       -4     
Flag Coverage Δ
rust 70.91% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.71% <ø> (ø)
src/stream/src/executor_v2/hash_agg.rs 95.89% <75.00%> (+0.48%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.00% <0.00%> (-0.27%) ⬇️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Zulai Wang <zl31wang@gmail.com>
@pleiadesian pleiadesian marked this pull request as ready for review April 18, 2022 23:52
@pleiadesian pleiadesian enabled auto-merge (squash) April 19, 2022 00:07
Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pleiadesian pleiadesian merged commit 77acdd1 into main Apr 19, 2022
@pleiadesian pleiadesian deleted the wzl/split-chunks-in-hash-agg branch April 19, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants