-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support drop source command #1895
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
+ Coverage 70.61% 70.69% +0.07%
==========================================
Files 611 612 +1
Lines 80066 80216 +150
==========================================
+ Hits 56536 56706 +170
+ Misses 23530 23510 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
need add a line ENABLE_KAFKA in risedev-components.ci.env |
Also I’d suggest putting source test in risedev-source workflow to make everything running in parallel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
What's changed and what's your intention?
Additionally, this pr includes:
./risedev dev ci-kafka
. This command will start a local kafka service (along with zookeeper.Checklist
Refer to a related PR or issue link (optional)