Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support drop source command #1895

Merged
merged 11 commits into from
Apr 18, 2022
Merged

feat: support drop source command #1895

merged 11 commits into from
Apr 18, 2022

Conversation

neverchanje
Copy link
Contributor

What's changed and what's your intention?

Additionally, this pr includes:

  • New risedev command: ./risedev dev ci-kafka. This command will start a local kafka service (along with zookeeper.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1895 (3f5c33e) into main (b088161) will increase coverage by 0.07%.
The diff coverage is 86.31%.

@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
+ Coverage   70.61%   70.69%   +0.07%     
==========================================
  Files         611      612       +1     
  Lines       80066    80216     +150     
==========================================
+ Hits        56536    56706     +170     
+ Misses      23530    23510      -20     
Flag Coverage Δ
rust 70.69% <86.31%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/catalog/schema_catalog.rs 78.66% <0.00%> (-3.28%) ⬇️
src/utils/pgwire/src/pg_response.rs 43.18% <0.00%> (-1.01%) ⬇️
src/frontend/src/handler/drop_mv.rs 47.05% <70.00%> (+47.05%) ⬆️
src/frontend/src/handler/drop_table.rs 90.90% <90.00%> (-1.10%) ⬇️
src/frontend/src/handler/drop_source.rs 94.20% <94.20%> (ø)
src/frontend/src/handler/mod.rs 59.45% <100.00%> (+5.40%) ⬆️
src/common/src/array/data_chunk_iter.rs 79.13% <0.00%> (-5.17%) ⬇️
src/common/src/util/ordered/serde.rs 98.19% <0.00%> (-1.33%) ⬇️
src/frontend/src/utils/condition.rs 95.65% <0.00%> (-0.60%) ⬇️
src/batch/src/executor/join/sort_merge_join.rs 73.37% <0.00%> (-0.39%) ⬇️
... and 19 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor

skyzh commented Apr 18, 2022

need add a line ENABLE_KAFKA in risedev-components.ci.env

@skyzh
Copy link
Contributor

skyzh commented Apr 18, 2022

Also I’d suggest putting source test in risedev-source workflow to make everything running in parallel.

.github/workflow-template/jobs/e2e-risedev.yml Outdated Show resolved Hide resolved
.github/workflow-template/jobs/e2e-risedev.yml Outdated Show resolved Hide resolved
src/frontend/src/handler/drop_mv.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
@neverchanje neverchanje enabled auto-merge (squash) April 18, 2022 09:31
@neverchanje neverchanje merged commit 0ba7c98 into main Apr 18, 2022
@neverchanje neverchanje deleted the wt-drop-source branch April 18, 2022 11:43
@neverchanje neverchanje added the user-facing-changes Contains changes that are visible to users label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants