Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use enum to dispatch SourceParser types #1896

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Conversation

neverchanje
Copy link
Contributor

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1896 (393c701) into main (5eb35c0) will decrease coverage by 0.00%.
The diff coverage is 10.71%.

@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
- Coverage   70.70%   70.70%   -0.01%     
==========================================
  Files         610      610              
  Lines       79832    79835       +3     
==========================================
  Hits        56446    56446              
- Misses      23386    23389       +3     
Flag Coverage Δ
rust 70.70% <10.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/source/src/connector_source.rs 0.00% <0.00%> (ø)
src/source/src/parser/mod.rs 0.00% <0.00%> (ø)
src/source/src/manager.rs 55.95% <50.00%> (+3.59%) ⬆️
src/source/src/high_level_kafka.rs 3.94% <100.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.26% <0.00%> (+0.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion merged commit 4d665a6 into main Apr 18, 2022
@tabVersion tabVersion deleted the wt-source-impl branch April 18, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants