Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support complex expr in group by #1899

Merged
merged 5 commits into from
Apr 18, 2022
Merged

Conversation

Enter-tainer
Copy link
Contributor

What's changed and what's your intention?

Previously, only InputRefs are allowed in the group by expression. This pr adds support for complex expressions in the group by.

Note that it seems that the current code already supports complex expressions in group by, so I only change the error code and the condition. Other chores like comment improvement and typo fix are also included in this pr.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

This pr resolves #1637.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1899 (65cf3d1) into main (2880cef) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main    #1899   +/-   ##
=======================================
  Coverage   70.60%   70.60%           
=======================================
  Files         611      611           
  Lines       79981    79995   +14     
=======================================
+ Hits        56467    56484   +17     
+ Misses      23514    23511    -3     
Flag Coverage Δ
rust 70.60% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.56% <90.90%> (+0.20%) ⬆️
src/meta/src/manager/stream_clients.rs 96.29% <0.00%> (+7.40%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@likg227 likg227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enter-tainer Enter-tainer marked this pull request as draft April 18, 2022 03:21
@likg227 likg227 requested a review from xiangjinwu April 18, 2022 03:47
@Enter-tainer Enter-tainer marked this pull request as ready for review April 18, 2022 04:10
@Enter-tainer Enter-tainer enabled auto-merge (squash) April 18, 2022 04:25
@Enter-tainer Enter-tainer merged commit b2ada4b into main Apr 18, 2022
@Enter-tainer Enter-tainer deleted the lwz/group-by branch April 18, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GROUP BY complex expressions
3 participants