-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support complex expr in group by #1899
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1899 +/- ##
=======================================
Coverage 70.60% 70.60%
=======================================
Files 611 611
Lines 79981 79995 +14
=======================================
+ Hits 56467 56484 +17
+ Misses 23514 23511 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed and what's your intention?
Previously, only
InputRef
s are allowed in thegroup by
expression. This pr adds support for complex expressions in thegroup by
.Note that it seems that the current code already supports complex expressions in
group by
, so I only change the error code and the condition. Other chores like comment improvement and typo fix are also included in this pr.Checklist
Refer to a related PR or issue link (optional)
This pr resolves #1637.