Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): prefer optimized_logical_plan in planner test #1911

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 18, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

  • If batch / stream plan is already available, remove logical_plan.
  • For logical_plan w/o correlated subquery, prefer optimized_logical_plan.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh enabled auto-merge (squash) April 18, 2022 07:05
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1911 (d275b41) into main (b2ada4b) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
+ Coverage   70.61%   70.66%   +0.04%     
==========================================
  Files         611      611              
  Lines       79994    79994              
==========================================
+ Hits        56491    56524      +33     
+ Misses      23503    23470      -33     
Flag Coverage Δ
rust 70.66% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/frontend/src/optimizer/rule/filter_join.rs 95.14% <0.00%> (+2.02%) ⬆️
src/storage/src/hummock/local_version_manager.rs 86.48% <0.00%> (+4.72%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 52.00% <0.00%> (+5.33%) ⬆️
src/meta/src/manager/stream_clients.rs 96.29% <0.00%> (+7.40%) ⬆️
.../frontend/src/optimizer/plan_node/logical_limit.rs 56.66% <0.00%> (+15.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 6678262 into main Apr 18, 2022
@skyzh skyzh deleted the skyzh/tpch-plan-test-modify branch April 18, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants