Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ss-bench): add options and clean its doc #1927

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Conversation

Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented Apr 19, 2022

What's changed and what's your intention?

  • Add Hummock options
  • Clear ss-bench doc

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@MrCroxx
Copy link
Contributor

MrCroxx commented Apr 19, 2022

I'm about to add threshold and capacity options for shared buffer, may be wait for it?

@Sunt-ing
Copy link
Contributor Author

@MrCroxx OK. Waiting for you.

@Sunt-ing Sunt-ing requested review from MrCroxx and removed request for Little-Wallace April 19, 2022 05:46
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1927 (d8b904b) into main (077d69a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1927      +/-   ##
==========================================
- Coverage   70.84%   70.83%   -0.02%     
==========================================
  Files         624      624              
  Lines       80027    80041      +14     
==========================================
- Hits        56698    56695       -3     
- Misses      23329    23346      +17     
Flag Coverage Δ
rust 70.83% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/bench/ss_bench/main.rs 0.70% <0.00%> (-0.08%) ⬇️
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/meta/src/barrier/mod.rs 70.06% <0.00%> (-0.35%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Sunt-ing Sunt-ing requested a review from hzxa21 April 20, 2022 03:28
@hzxa21 hzxa21 changed the title chore(ss-bench): add optiosn and clean its doc chore(ss-bench): add options and clean its doc Apr 20, 2022
@Sunt-ing Sunt-ing merged commit 5652c8d into main Apr 20, 2022
@Sunt-ing Sunt-ing deleted the sunt_add_params branch April 20, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants