refactor(frontend): cleanup infer_type and align with pg #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1931 +/- ##
==========================================
- Coverage 70.94% 70.93% -0.02%
==========================================
Files 617 617
Lines 79946 79870 -76
==========================================
- Hits 56719 56652 -67
+ Misses 23227 23218 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xiangjinwu
force-pushed
the
rust-frontend-refactor-infer-type
branch
from
2818fc0
to
6793bd4
Compare
xiangjinwu
changed the title
neverchanje
reviewed
Apr 19, 2022
| E::Equal, | ||
| E::NotEqual, | ||
| E::LessThan, | ||
| E::LessThanOrEqual, | ||
| E::GreaterThan, | ||
| E::GreaterThanOrEqual, | ||
| E::In, |
There was a problem hiding this comment.
In is a variadic function that cannot be handled by this func signature map lookup. It will be handled in a later refactor together with case when.
#1910 (comment)
There was a problem hiding this comment.
My fault to add it. It should not have been to put in this map.
BowenXiao1999
approved these changes
Apr 19, 2022
neverchanje
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
num_typesshould beint2->int4->int8->numeric->float4->float8.build_binary_funcsproduces all combinations ofexprs * arg1 * arg2and requires the return types to be the same, which is only useful forcmp.Checklist
Refer to a related PR or issue link (optional)