-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(binder): split relation binding to sub mods #1953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 725 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
720 | 3 | 2 | 0 |
Click to see the invalid file list
- src/frontend/src/binder/relation/join.rs
- src/frontend/src/binder/relation/subquery.rs
- src/frontend/src/binder/relation/table_or_source.rs
Codecov Report
@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
- Coverage 70.94% 70.89% -0.06%
==========================================
Files 617 621 +4
Lines 79946 79964 +18
==========================================
- Hits 56719 56688 -31
- Misses 23227 23276 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
What's changed and what's your intention?
Split the binding of table_or_source, subquery, window_table_function, join to its own file.
This PR is purely code movement and the table_or_source refactor will be handled separately.
Not handled:
bind_table
is only used bydelete
to evaluate predicates inwhere
.bind_table_source
is only used byinsert
anddelete
as the target.BoundTableSource
is also only used here.bind_table_or_source
is used by the most common path ofselect from
(batch & stream).Ideally there should only be a
bind_table -> BoundBaseTable
, abind_source -> BoundSource
, and abind_table_or_source -> Relation
.Checklist
- [ ] I have written necessary docs and comments- [ ] I have added necessary unit tests and integration testsRefer to a related PR or issue link (optional)