Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(binder): split relation binding to sub mods #1953

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Apr 19, 2022

What's changed and what's your intention?

Split the binding of table_or_source, subquery, window_table_function, join to its own file.

This PR is purely code movement and the table_or_source refactor will be handled separately.

Not handled:

  • bind_table is only used by delete to evaluate predicates in where.
  • bind_table_source is only used by insert and delete as the target. BoundTableSource is also only used here.
  • bind_table_or_source is used by the most common path of select from (batch & stream).

Ideally there should only be a bind_table -> BoundBaseTable, a bind_source -> BoundSource, and a bind_table_or_source -> Relation.

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 725 files.

Valid Invalid Ignored Fixed
720 3 2 0
Click to see the invalid file list
  • src/frontend/src/binder/relation/join.rs
  • src/frontend/src/binder/relation/subquery.rs
  • src/frontend/src/binder/relation/table_or_source.rs

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1953 (6ffb0c6) into main (5160586) will decrease coverage by 0.05%.
The diff coverage is 83.81%.

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   70.94%   70.89%   -0.06%     
==========================================
  Files         617      621       +4     
  Lines       79946    79964      +18     
==========================================
- Hits        56719    56688      -31     
- Misses      23227    23276      +49     
Flag Coverage Δ
rust 70.89% <83.81%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/mod.rs 100.00% <ø> (ø)
...ntend/src/binder/relation/window_table_function.rs 68.60% <ø> (ø)
src/frontend/src/binder/relation/join.rs 77.19% <77.19%> (ø)
src/frontend/src/binder/relation/mod.rs 82.22% <82.22%> (ø)
...rc/frontend/src/binder/relation/table_or_source.rs 86.60% <86.60%> (ø)
src/frontend/src/binder/relation/subquery.rs 94.73% <94.73%> (ø)
src/common/src/array/stream_chunk_iter.rs 57.54% <0.00%> (-41.24%) ⬇️
src/common/src/test_utils/test_stream_chunk.rs 40.45% <0.00%> (-28.38%) ⬇️
src/frontend/src/session.rs 45.64% <0.00%> (-0.68%) ⬇️
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
... and 24 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjinwu xiangjinwu marked this pull request as ready for review April 19, 2022 10:09
@xiangjinwu xiangjinwu merged commit ff59232 into main Apr 20, 2022
@xiangjinwu xiangjinwu deleted the rust-frontend-refactor-bind-relation-r0 branch April 20, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants