Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): use async stream for dispatcher #1955

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1955 (0db767d) into main (470a18a) will increase coverage by 0.01%.
The diff coverage is 86.84%.

@@            Coverage Diff             @@
##             main    #1955      +/-   ##
==========================================
+ Coverage   70.92%   70.94%   +0.01%     
==========================================
  Files         619      619              
  Lines       80106    80089      -17     
==========================================
  Hits        56816    56816              
+ Misses      23290    23273      -17     
Flag Coverage Δ
rust 70.94% <86.84%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/mod.rs 51.51% <ø> (ø)
src/stream/src/executor_v2/mod.rs 64.44% <ø> (-0.78%) ⬇️
src/stream/src/task/stream_manager.rs 0.00% <0.00%> (ø)
src/stream/src/executor/actor.rs 93.33% <88.88%> (-1.12%) ⬇️
src/stream/src/executor/dispatch.rs 76.07% <100.00%> (-0.25%) ⬇️
src/stream/src/executor/integration_tests.rs 95.67% <100.00%> (-0.08%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.00% <0.00%> (-0.27%) ⬇️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️
src/storage/src/hummock/local_version_manager.rs 86.48% <0.00%> (+4.72%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 52.00% <0.00%> (+5.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao merged commit f8adf2e into main Apr 20, 2022
@BugenZhao BugenZhao deleted the bz/async-stream-dispatcher branch April 20, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants