Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove lifetime on iterators #1956

Merged
merged 1 commit into from
Apr 19, 2022
Merged

refactor(storage): remove lifetime on iterators #1956

merged 1 commit into from
Apr 19, 2022

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Apr 19, 2022

What's changed and what's your intention?

Remove all the lifetime associated with iterators defined in Hummock.

This PR conflicts with PR #1928 on use XXX statements only at one location. It seems #1928 is ready and this PR will wait for it to be merged first.

After this refactoring, we can bound the trait StateStoreIter by 'static. This will bypass the compiler limitation described in #1930 when Send is used to bound NextFuture in StateStoreIter.

Refer to a related PR or issue link (optional)

#1930

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@77acdd1). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head a11a775 differs from pull request most recent head fdc8832. Consider uploading reports for the commit fdc8832 to get more accurate results

@@           Coverage Diff           @@
##             main    #1956   +/-   ##
=======================================
  Coverage        ?   70.92%           
=======================================
  Files           ?      619           
  Lines           ?    80106           
  Branches        ?        0           
=======================================
  Hits            ?    56815           
  Misses          ?    23291           
  Partials        ?        0           
Flag Coverage Δ
rust 70.92% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/iterator/merge.rs 95.77% <ø> (ø)
src/storage/src/hummock/iterator/mod.rs 100.00% <ø> (ø)
src/storage/src/hummock/iterator/reverse_merge.rs 93.67% <ø> (ø)
src/storage/src/hummock/compactor.rs 67.44% <100.00%> (ø)
src/storage/src/hummock/iterator/merge_inner.rs 83.78% <100.00%> (ø)
src/storage/src/hummock/iterator/reverse_user.rs 95.72% <100.00%> (ø)
src/storage/src/hummock/iterator/test_utils.rs 76.53% <100.00%> (ø)
src/storage/src/hummock/iterator/user.rs 94.40% <100.00%> (ø)
src/storage/src/hummock/state_store.rs 70.50% <100.00%> (ø)
src/storage/src/hummock/test_utils.rs 81.37% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants