-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(streaming): ensure schema and order are consistent in lookup #1970
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1970 +/- ##
==========================================
+ Coverage 70.98% 71.00% +0.02%
==========================================
Files 624 624
Lines 80480 80557 +77
==========================================
+ Hits 57126 57198 +72
- Misses 23354 23359 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
also hold until #1967? Modification on the schema part will easily break some schema checks. Should wait until there's a schema check executor so that we can be sure that there's no schema mismatch problems. |
Good idea. I believe it will be quick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
By the way, IIUC, there is no e2e test for looking up shared state now?
Oh it's covered in #1978 |
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
LGTM |
Signed-off-by: Alex Chi iskyzh@gmail.com
What's changed and what's your intention?
Currently, all TPC-H can pass under delta join. (Only tested single node).
This PR fixes a lot of bugs. Now we ensures that:
stream + arrangement
internally, and then reordered by column reordering parameters.stream
thenarrangement
.Checklist
Refer to a related PR or issue link (optional)
blocked by #1901, causing MV with delta join cannot be dropped.
close #1882