Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docker compose dependencies #1972

Merged
merged 2 commits into from
Apr 20, 2022
Merged

chore: fix docker compose dependencies #1972

merged 2 commits into from
Apr 20, 2022

Conversation

tabVersion
Copy link
Contributor

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

we do not rely on confluentinc/cp-kafkacat, roll back to edenhill/kafkacat:1.6.0

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@tabVersion tabVersion enabled auto-merge (squash) April 20, 2022 07:27
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1972 (c215563) into main (8fd3e9d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
- Coverage   70.99%   70.98%   -0.01%     
==========================================
  Files         625      625              
  Lines       80565    80515      -50     
==========================================
- Hits        57198    57156      -42     
+ Misses      23367    23359       -8     
Flag Coverage Δ
rust 70.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/receiver.rs 46.42% <0.00%> (-32.15%) ⬇️
src/meta/src/manager/stream_clients.rs 88.88% <0.00%> (-7.41%) ⬇️
src/stream/src/executor_v2/v1_compat.rs 32.79% <0.00%> (-4.66%) ⬇️
src/stream/src/executor/mod.rs 48.57% <0.00%> (-2.95%) ⬇️
src/stream/src/executor_v2/global_simple_agg.rs 94.27% <0.00%> (-2.65%) ⬇️
src/stream/src/task/mod.rs 38.46% <0.00%> (-2.24%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.02% <0.00%> (-0.27%) ⬇️
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️
src/stream/src/executor/integration_tests.rs 95.56% <0.00%> (-0.11%) ⬇️
src/stream/src/executor/chain.rs 0.00% <0.00%> (ø)
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: tabVersion <tabvision@bupt.icu>
@tabVersion tabVersion changed the title chore: fix kafka cat dependency chore: fix docker compose dependencies Apr 20, 2022
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion merged commit 67c2a15 into main Apr 20, 2022
@tabVersion tabVersion deleted the tabVersion-patch-1 branch April 20, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants