Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use random instead of sleep #1975

Merged
merged 1 commit into from
Apr 20, 2022
Merged

fix: use random instead of sleep #1975

merged 1 commit into from
Apr 20, 2022

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Apr 20, 2022

Signed-off-by: Peng Chen peng@singularity-data.com

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

as title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Peng Chen <peng@singularity-data.com>
@github-actions github-actions bot added the type/fix Bug fix label Apr 20, 2022
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert timeout related changes and close #1973

@shanicky shanicky linked an issue Apr 20, 2022 that may be closed by this pull request
@shanicky shanicky enabled auto-merge (squash) April 20, 2022 08:02
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1975 (00ffe2d) into main (b46144a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1975   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files         625      625           
  Lines       80589    80587    -2     
=======================================
- Hits        57181    57180    -1     
+ Misses      23408    23407    -1     
Flag Coverage Δ
rust 70.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/source.rs 74.70% <100.00%> (-0.12%) ⬇️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@shanicky shanicky merged commit 06e0f62 into main Apr 20, 2022
@shanicky shanicky deleted the peng/row_id_sleep branch April 20, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: fix regression caused by std::thread::sleep
3 participants