Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support HOP window #1980

Merged
merged 11 commits into from
Apr 20, 2022
Merged

feat(frontend): support HOP window #1980

merged 11 commits into from
Apr 20, 2022

Conversation

TennyZhuang
Copy link
Collaborator

@TennyZhuang TennyZhuang commented Apr 20, 2022

Signed-off-by: TennyZhuang zty0826@gmail.com

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

The PR generally implemented HOP window in rust frontend, but not tested since column pruning is incorrect. @st1page will fix it in later PR.

Checklist

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 732 files.

Valid Invalid Ignored Fixed
729 1 2 0
Click to see the invalid file list
  • src/frontend/src/optimizer/plan_node/stream_hop_window.rs

TennyZhuang and others added 7 commits April 20, 2022 16:42
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1980 (4b8d55d) into main (ffc46fc) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   70.90%   70.77%   -0.14%     
==========================================
  Files         625      627       +2     
  Lines       80660    80812     +152     
==========================================
+ Hits        57194    57195       +1     
- Misses      23466    23617     +151     
Flag Coverage Δ
rust 70.77% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/catalog/schema.rs 78.62% <0.00%> (-5.12%) ⬇️
src/frontend/src/expr/input_ref.rs 92.64% <ø> (ø)
src/frontend/src/expr/literal.rs 65.45% <ø> (ø)
...frontend/src/optimizer/plan_node/logical_filter.rs 97.79% <ø> (ø)
...tend/src/optimizer/plan_node/logical_hop_window.rs 0.00% <0.00%> (ø)
src/frontend/src/optimizer/plan_node/mod.rs 98.00% <ø> (ø)
src/frontend/src/optimizer/plan_node/plan_base.rs 91.66% <ø> (ø)
...ntend/src/optimizer/plan_node/stream_hop_window.rs 0.00% <0.00%> (ø)
src/frontend/src/planner/relation.rs 70.64% <0.00%> (-16.86%) ⬇️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang marked this pull request as ready for review April 20, 2022 16:20
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang TennyZhuang merged commit 30bae6b into main Apr 20, 2022
@TennyZhuang TennyZhuang deleted the feat/hop-window-frontend branch April 20, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants