-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support HOP window #1980
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 732 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
729 | 1 | 2 | 0 |
Click to see the invalid file list
- src/frontend/src/optimizer/plan_node/stream_hop_window.rs
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
- Coverage 70.90% 70.77% -0.14%
==========================================
Files 625 627 +2
Lines 80660 80812 +152
==========================================
+ Hits 57194 57195 +1
- Misses 23466 23617 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: TennyZhuang <zty0826@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: TennyZhuang zty0826@gmail.com
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
The PR generally implemented HOP window in rust frontend, but not tested since column pruning is incorrect. @st1page will fix it in later PR.
Checklist
Refer to a related PR or issue link (optional)