refactor(batch): Use futures-async-stream to implement insert executor #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make D2Lark a reviewer |
BugenZhao
reviewed
Apr 21, 2022
src/batch/src/executor2/insert.rs
Outdated
| impl InsertExecutor2 { | ||
| #[try_stream(boxed, ok = DataChunk, error = RwError)] | ||
| async fn do_execute(mut self: Box<Self>) { | ||
| if !self.executed { |
There was a problem hiding this comment.
This field is no longer necessary since do_execute takes the ownership of this executor.
| insert.next().await?; | ||
| insert.close().await?; | ||
| let mut stream = insert.execute(); | ||
| let _ = stream.next().await.unwrap(); |
There was a problem hiding this comment.
This seems to return a Result. We may throw the error by ? here.
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 70.79% 70.80%
=======================================
Files 628 628
Lines 80785 80734 -51
=======================================
- Hits 57193 57161 -32
+ Misses 23592 23573 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Please resolve conflict first. |
|
bors try |
tryTimed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Implement Insert using Executor2 trait.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
close #1937