Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(streaming): only export traced error type #2009

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao i@bugenzhao.com

What's changed and what's your intention?

As title. This PR makes untraced error private and only export traced error interface for streaming, like what did in StorageError.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@skyzh
Copy link
Contributor

skyzh commented Apr 21, 2022

The time out looks quite suspicious. Everything seems stuck after 1min.

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao
Copy link
Member Author

The time out looks quite suspicious. Everything seems stuck after 1min.

It seems there's an actor who failed to report the finish of creating mview. It might be related to the rearranged chain. Let's investigate it next few days. 🤣

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #2009 (b4a7f7b) into main (f9e486e) will increase coverage by 0.00%.
The diff coverage is 34.54%.

@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   70.64%   70.65%           
=======================================
  Files         629      629           
  Lines       80959    80954    -5     
=======================================
+ Hits        57195    57197    +2     
+ Misses      23764    23757    -7     
Flag Coverage Δ
rust 70.65% <34.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/debug/trace.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/debug/update_check.rs 94.02% <0.00%> (ø)
src/stream/src/executor_v2/error.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/rearranged_chain.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/union.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/hop_window.rs 80.55% <20.00%> (ø)
src/stream/src/executor_v2/hash_agg.rs 95.89% <50.00%> (ø)
src/stream/src/executor_v2/batch_query.rs 85.88% <100.00%> (ø)
src/stream/src/executor_v2/chain.rs 78.30% <100.00%> (ø)
src/stream/src/executor_v2/debug/epoch_check.rs 96.36% <100.00%> (ø)
... and 13 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao merged commit d602256 into main Apr 21, 2022
@BugenZhao BugenZhao deleted the bz/unify-stream-executor-error branch April 21, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants