Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(batch): Use futures-async-stream to implement delete executor #2010

Merged
merged 7 commits into from
Apr 21, 2022
Merged

refactor(batch): Use futures-async-stream to implement delete executor #2010

merged 7 commits into from
Apr 21, 2022

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented Apr 21, 2022

Signed-off-by: d2lark lichengamoy@gmail.com

What's changed and what's your intention?

Implement delete using Executor2 trait.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1933

@D2Lark
impl delete executor2
3c59807 
Signed-off-by: d2lark <lichengamoy@gmail.com>
@D2Lark D2Lark changed the title refactor(batch): Use futures-async-stream to implement deleteexecutor refactor(batch): Use futures-async-stream to implement delete executor Apr 21, 2022
@liurenjie1024
Copy link
Contributor

bors try

@bors
Copy link

bors bot commented Apr 21, 2022

try

Merge conflict.

@liurenjie1024
Copy link
Contributor

bors try

@liurenjie1024
Copy link
Contributor

bors try

@bors
Copy link

bors bot commented Apr 21, 2022

try

Already running a review

@bors
Copy link

bors bot commented Apr 21, 2022

try

Timed out.

@liurenjie1024
Copy link
Contributor

bors try

@bors
Copy link

bors bot commented Apr 21, 2022

try

Timed out.

@liurenjie1024
Copy link
Contributor

bors try

@bors
Copy link

bors bot commented Apr 21, 2022

try

Timed out.

@liurenjie1024 liurenjie1024 merged commit 2027b1f into risingwavelabs:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use futures-async-stream to refactor DeleteExecutor.
3 participants
@D2Lark @liurenjie1024 @BugenZhao