feat(meta): add support for sending notifications asynchronously #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
reviewed
Apr 21, 2022
| } | ||
| }; | ||
| if let Some(tx) = task.callback_tx { | ||
| tx.send(version).unwrap(); |
There was a problem hiding this comment.
Suggest warning here or it may panic on meta exiting.
Suggested change
| tx.send(version).unwrap(); | |
| if tx.send(version).is_err() { | |
| warn!(...); | |
| } |
There was a problem hiding this comment.
I think we can change this after ci error happens.
Codecov Report
@@ Coverage Diff @@
## main #2029 +/- ##
==========================================
- Coverage 70.79% 70.67% -0.13%
==========================================
Files 628 629 +1
Lines 80785 81015 +230
==========================================
+ Hits 57193 57257 +64
- Misses 23592 23758 +166
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
zwang28
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Add support for sending notifications asynchronously.
It is used where it is only necessary to ensure that the message will be sent, but not that the message must be sent successfully at the end of the method.
Checklist
Refer to a related PR or issue link (optional)