-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change the encoding of actor mapping in grpc #2031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 735 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
732 | 1 | 2 | 0 |
Click to see the invalid file list
- src/common/src/util/compress.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…gularity-data/risingwave into fix/dispatcher-grpc-encoding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd prefer to store offsets
in the mapping, so that things might be clearer, and follows most of the developers' conventions. e.g., if we have:
1, 1, 1, 2, 2, 2, 3, 3, 3
,
then we store 0, 3, 6
in offsets
, and 1, 2, 3
in data.
Then we need another field for the length. 😁 |
We can record n+1 offsets 🤪 |
Codecov Report
@@ Coverage Diff @@
## main #2031 +/- ##
==========================================
+ Coverage 70.64% 70.95% +0.30%
==========================================
Files 629 632 +3
Lines 80959 81082 +123
==========================================
+ Hits 57195 57529 +334
+ Misses 23764 23553 -211
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Then there will be little difference compared with current encoding 🤣 |
Guess 65536 is still too much to process, it seems that e2e timed out? |
Might find out the reason later 🤣 |
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)
#1443