Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(frontend): meaningful names for basic_query_{1,2,3}.yaml #2034

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Apr 21, 2022

What's changed and what's your intention?

  • basic_query_1 -> basic_query: simple values, scan, filter, project, insert, delete
  • basic_query_2 -> agg
  • basic_query_3 -> expr: literal, cast, bool, cmp, atm, temporal, string, etc

Also moves test cases to designated files: +187 -187.

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the component/test Test related issue. label Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #2034 (be0b206) into main (579f845) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2034   +/-   ##
=======================================
  Coverage   70.65%   70.65%           
=======================================
  Files         629      629           
  Lines       80967    80967           
=======================================
+ Hits        57208    57210    +2     
+ Misses      23759    23757    -2     
Flag Coverage Δ
rust 70.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
src/meta/src/barrier/mod.rs 69.33% <0.00%> (+0.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjinwu xiangjinwu merged commit 82e538b into main Apr 21, 2022
@xiangjinwu xiangjinwu deleted the rust-frontend-tests-rename branch April 21, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants