Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Use futures-async-stream to implement limit executor #2050

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

Fedomn
Copy link
Contributor

@Fedomn Fedomn commented Apr 22, 2022

Signed-off-by: Fedomn fedomn.ma@gmail.com

What's changed and what's your intention?

Use futures-async-stream to refactor LimitExecutor

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1938

src/batch/src/executor2/limit.rs Show resolved Hide resolved
src/batch/src/executor2/limit.rs Outdated Show resolved Hide resolved
Signed-off-by: Fedomn <fedomn.ma@gmail.com>
Signed-off-by: Fedomn <fedomn.ma@gmail.com>
Signed-off-by: Fedomn <fedomn.ma@gmail.com>
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liurenjie1024
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 22, 2022
@liurenjie1024 liurenjie1024 merged commit f34b3a8 into risingwavelabs:main Apr 22, 2022
@Fedomn Fedomn deleted the issue-1938 branch April 22, 2022 08:08
@bors
Copy link

bors bot commented Apr 22, 2022

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use futures-async-stream to refactor LimitExecutor.
2 participants