Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimzier): pk derive for hop window #2052

Merged
merged 3 commits into from
Apr 22, 2022
Merged

feat(optimzier): pk derive for hop window #2052

merged 3 commits into from
Apr 22, 2022

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Apr 22, 2022

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2052 (6594112) into main (abb87c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2052   +/-   ##
=======================================
  Coverage   70.93%   70.93%           
=======================================
  Files         633      633           
  Lines       81126    81127    +1     
=======================================
+ Hits        57548    57550    +2     
+ Misses      23578    23577    -1     
Flag Coverage Δ
rust 70.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/optimizer/plan_node/logical_hop_window.rs 95.23% <100.00%> (+0.03%) ⬆️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@st1page st1page enabled auto-merge (squash) April 22, 2022 06:06
@st1page st1page merged commit 58b97fa into main Apr 22, 2022
@st1page st1page deleted the sts/hop_pk_derive branch April 22, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants