Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor): e2e implement hop_window #2055

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

TennyZhuang
Copy link
Collaborator

@TennyZhuang TennyZhuang commented Apr 22, 2022

Signed-off-by: TennyZhuang zty0826@gmail.com

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

  • Implement HopWindowExecutorBuilder
  • Add HopWindow e2e test

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2055 (ec7ce4e) into main (58b97fa) will decrease coverage by 0.04%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
- Coverage   70.95%   70.91%   -0.05%     
==========================================
  Files         633      633              
  Lines       81175    81217      +42     
==========================================
- Hits        57601    57595       -6     
- Misses      23574    23622      +48     
Flag Coverage Δ
rust 70.91% <14.28%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/interval.rs 73.36% <0.00%> (-5.56%) ⬇️
...ntend/src/optimizer/plan_node/stream_hop_window.rs 68.57% <0.00%> (+5.41%) ⬆️
src/stream/src/executor/mod.rs 48.57% <ø> (ø)
src/stream/src/executor_v2/hop_window.rs 66.82% <0.00%> (-13.74%) ⬇️
src/stream/src/executor_v2/mod.rs 80.00% <ø> (ø)
src/frontend/src/expr/input_ref.rs 92.42% <100.00%> (-0.23%) ⬇️
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.69% <100.00%> (-0.02%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit 6e04e84 into main Apr 22, 2022
@TennyZhuang TennyZhuang deleted the feat/hop-window-all branch April 22, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants