-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): Use futures-async-stream to implement Projection executor #2058
refactor(batch): Use futures-async-stream to implement Projection executor #2058
Conversation
Signed-off-by: d2lark <lichengamoy@gmail.com>
bors try |
bors seems failed, I will push it to another branch and merge it if CI passed. |
Codecov Report
@@ Coverage Diff @@
## main #2058 +/- ##
==========================================
- Coverage 70.86% 70.84% -0.02%
==========================================
Files 633 633
Lines 81404 81382 -22
==========================================
- Hits 57683 57654 -29
- Misses 23721 23728 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
} | ||
|
||
fn identity(&self) -> &str { | ||
"TraceExecutor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
identity is incorrect?
Signed-off-by: d2lark <lichengamoy@gmail.com>
CI passed, Thanks! |
What's changed and what's your intention?
Implement Projection using Executor2 trait.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
close #1941