Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Use futures-async-stream to implement Projection executor #2058

Merged
merged 5 commits into from
Apr 24, 2022

Conversation

D2Lark
Copy link
Contributor

@D2Lark D2Lark commented Apr 22, 2022

What's changed and what's your intention?

Implement Projection using Executor2 trait.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1941

Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
@TennyZhuang
Copy link
Collaborator

bors try

@TennyZhuang
Copy link
Collaborator

bors seems failed, I will push it to another branch and merge it if CI passed.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2058 (c579d74) into main (f1b7bcf) will decrease coverage by 0.01%.
The diff coverage is 69.90%.

@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
- Coverage   70.86%   70.84%   -0.02%     
==========================================
  Files         633      633              
  Lines       81404    81382      -22     
==========================================
- Hits        57683    57654      -29     
- Misses      23721    23728       +7     
Flag Coverage Δ
rust 70.84% <69.90%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 62.65% <ø> (ø)
src/batch/src/executor2/mod.rs 100.00% <ø> (ø)
src/batch/src/executor2/projection.rs 69.90% <69.90%> (ø)
src/batch/src/executor/executor2_wrapper.rs 41.02% <0.00%> (-35.90%) ⬇️
src/batch/src/executor/projection.rs
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.29% <0.00%> (+0.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

}

fn identity(&self) -> &str {
"TraceExecutor"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identity is incorrect?

@TennyZhuang
Copy link
Collaborator

@risingwavelabs risingwavelabs deleted a comment from bors bot Apr 24, 2022
@risingwavelabs risingwavelabs deleted a comment from liurenjie1024 Apr 24, 2022
@TennyZhuang
Copy link
Collaborator

CI passed, Thanks!

@TennyZhuang TennyZhuang merged commit c35ac90 into risingwavelabs:main Apr 24, 2022
@D2Lark D2Lark deleted the impl_project_executor2 branch April 24, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use futures-async-stream to refactor ProjectionExecutor
3 participants