refactor(fragmenter): make graph its submodule & some refactors to improve style & readability
#2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2066 +/- ##
==========================================
- Coverage 70.83% 70.82% -0.01%
==========================================
Files 633 633
Lines 81240 81365 +125
==========================================
+ Hits 57544 57628 +84
- Misses 23696 23737 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
xxchan
changed the title
graph submodule of fragmentergraph submodule of fragmenter
xxchan
changed the title
graph submodule of fragmentergraph submodule of fragmenter & some style refactors
This reverts commit a576cc3.
xxchan
changed the title
graph submodule of fragmenter & some style refactorsgraph its submodule & some refactors to improve style & readability
skyzh
approved these changes
Apr 24, 2022
| /// dependent table ids | ||
| dependent_table_ids: HashSet<TableId>, | ||
| /// upstream dispatch keys | ||
| distribution_keys: Vec<i32>, |
There was a problem hiding this comment.
There should be multiple sets of distribution keys, one set per upstream?
There was a problem hiding this comment.
cc @zbzbw why there's only one set of distribution keys? 🤣
There was a problem hiding this comment.
cc @zbzbw why there's only one set of distribution keys? 🤣
My fault😢. The comment was misleading, this field contains current fragment's distribution key instead of upstream.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zbzbw
suggested changes
Apr 24, 2022
yezizp2012
approved these changes
Apr 24, 2022
zbzbw
approved these changes
Apr 24, 2022
Co-authored-by: Zhou, Bowen <44491322+zbzbw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
graphis only used therepub, to make the dependency more clearremove(Next PR)fragment_graph&stream_graph_builderfrom fields (make them as variables/parameters), so that the relationship is more clear, and mutable variables are more distinguishable.Checklist
[ ] I have written necessary docs and comments[ ] I have added necessary unit tests and integration testsRefer to a related PR or issue link (optional)