-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(batch): Use futures-async-stream to implement TopN executor #2073
Conversation
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
There are unresolved conflicts, it's meaningless to trigger it now ( |
Signed-off-by: d2lark <lichengamoy@gmail.com>
…gwave into impl_topn_executor2
Hi, @D2Lark since bors failed, I just cloned your branch and push it to our repo to submit a PR. Sorry for the inconvenience, and we are working on it. |
It's OK, thanks for your help~ |
Codecov Report
@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
- Coverage 71.04% 71.03% -0.01%
==========================================
Files 635 635
Lines 81620 81609 -11
==========================================
- Hits 57984 57975 -9
+ Misses 23636 23634 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Checkes all passed. |
What's changed and what's your intention?
Implement TopN using Executor2 trait.
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)
close #1945