Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): Use futures-async-stream to implement TopN executor #2073

Merged
merged 15 commits into from
Apr 24, 2022

Conversation

liurenjie1024
Copy link
Contributor

What's changed and what's your intention?

Implement TopN using Executor2 trait.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1945

Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
Signed-off-by: d2lark <lichengamoy@gmail.com>
@TennyZhuang
Copy link
Collaborator

There are unresolved conflicts, it's meaningless to trigger it now (

@D2Lark
Copy link
Contributor

D2Lark commented Apr 24, 2022

Why doesn't my local commit appear in the PR?
image

maybe because of this?
image

@liurenjie1024
Copy link
Contributor Author

Hi, @D2Lark since bors failed, I just cloned your branch and push it to our repo to submit a PR. Sorry for the inconvenience, and we are working on it.

@D2Lark
Copy link
Contributor

D2Lark commented Apr 24, 2022

It's OK, thanks for your help~

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2073 (2d33dac) into main (3b06cfd) will decrease coverage by 0.00%.
The diff coverage is 59.25%.

@@            Coverage Diff             @@
##             main    #2073      +/-   ##
==========================================
- Coverage   71.04%   71.03%   -0.01%     
==========================================
  Files         635      635              
  Lines       81620    81609      -11     
==========================================
- Hits        57984    57975       -9     
+ Misses      23636    23634       -2     
Flag Coverage Δ
rust 71.03% <59.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 62.65% <ø> (ø)
src/batch/src/executor2/mod.rs 100.00% <ø> (ø)
src/batch/src/executor2/top_n.rs 80.29% <59.25%> (ø)
src/meta/src/barrier/mod.rs 69.33% <0.00%> (+0.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@liurenjie1024 liurenjie1024 enabled auto-merge (squash) April 24, 2022 07:37
@liurenjie1024 liurenjie1024 enabled auto-merge (squash) April 24, 2022 07:38
@liurenjie1024 liurenjie1024 merged commit 3076561 into main Apr 24, 2022
@liurenjie1024 liurenjie1024 deleted the forks/impl_topn_executor2 branch April 24, 2022 07:38
@liurenjie1024
Copy link
Contributor Author

Checkes all passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use futures-async-stream to refactor TopNExecutor
3 participants