refactor(fragmenter): split fileds into different structs -- lose weight! #2074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Mutable states are split into
BuildFragmentGraphState
andBuildActorGraphState
The two stage of fragmenter is orthogonal, after splitting the mutable states into two places, what variables are mutated/referenced become more clear, and only
&self
is used forStreamFragmenter
For the remaining fields,
XxManagerRef
can be used directly thus removed.parallel_degree
andis_legacy_frontend
are kept for simplicityChecklist
[ ] I have written necessary docs and comments[ ] I have added necessary unit tests and integration testsRefer to a related PR or issue link (optional)