Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fragmenter): split fileds into different structs -- lose weight! #2074

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 24, 2022

What's changed and what's your intention?

  • Mutable states are split into BuildFragmentGraphState and BuildActorGraphState

    The two stage of fragmenter is orthogonal, after splitting the mutable states into two places, what variables are mutated/referenced become more clear, and only &self is used for StreamFragmenter

  • For the remaining fields, XxManagerRef can be used directly thus removed. parallel_degree and is_legacy_frontend are kept for simplicity

Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@xxchan xxchan changed the title refactor(fragmenter): split fileds into different structs refactor(fragmenter): split fileds into different structs -- lose weight! Apr 24, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2074 (84aa937) into main (1d90e34) will decrease coverage by 0.01%.
The diff coverage is 64.89%.

@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
- Coverage   70.82%   70.81%   -0.02%     
==========================================
  Files         633      633              
  Lines       81374    81416      +42     
==========================================
+ Hits        57637    57658      +21     
- Misses      23737    23758      +21     
Flag Coverage Δ
rust 70.81% <64.89%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/meta/src/stream/fragmenter/rewrite/delta_join.rs 0.00% <0.00%> (ø)
src/meta/src/stream/fragmenter/mod.rs 84.13% <90.90%> (+0.95%) ⬆️
...meta/src/stream/fragmenter/graph/fragment_graph.rs 97.14% <100.00%> (-0.14%) ⬇️
...c/meta/src/stream/fragmenter/graph/stream_graph.rs 64.04% <100.00%> (ø)
src/cmd/src/bin/frontend_node.rs 0.00% <0.00%> (-16.67%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😋😋😋

@skyzh skyzh merged commit 88612d9 into main Apr 24, 2022
@skyzh skyzh deleted the xxchan/fr branch April 24, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants