Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fragmenter): clean up some outdated/verbose comments #2077

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 24, 2022

What's changed and what's your intention?

as title. The code are self-explanatory now, so they are not needed

Checklist

  • [ ] I have written necessary docs and comments
  • [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@xxchan xxchan enabled auto-merge (squash) April 24, 2022 05:30
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2077 (39815ca) into main (88612d9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2077   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files         633      633           
  Lines       81416    81412    -4     
=======================================
- Hits        57655    57653    -2     
+ Misses      23761    23759    -2     
Flag Coverage Δ
rust 70.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/stream/fragmenter/mod.rs 83.95% <ø> (-0.19%) ⬇️
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.29% <0.00%> (+0.26%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xxchan xxchan merged commit 0b1205c into main Apr 24, 2022
@xxchan xxchan deleted the xxchan/patch1 branch April 24, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants