refactor(meta): destruct create mv ctx in parameter site

[xxchan]

What's changed and what's your intention?

because ctx is consumed (thus splitted) here. (And in my opinion the large struct should not be passed later)

In this way we can see clearer what is used/mutated

Checklist

• [ ] I have written necessary docs and comments
• [ ] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

[skyzh]

What about defining the CreateMaterializedViewContext with &mut X inside? I think in this way, we can also know mutable / immutable, while not having to much parameters?

[xxchan]

&mut field doesn't work because then we will have to move ctx into resolve_chain_node.

Actually only resolve_chain_node needs to pass ctx (used 4/9 of its fields, 2 mutable). Maybe we can refactor the logic of chain later

[codecov]

Codecov Report

Merging #2080 (9ee2582) into main (3b06cfd) will increase coverage by 0.02%.
The diff coverage is 67.39%.

@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
+ Coverage   71.04%   71.06%   +0.02%     
==========================================
  Files         635      635              
  Lines       81620    81644      +24     
==========================================
+ Hits        57984    58020      +36     
+ Misses      23636    23624      -12     

Flag	Coverage Δ
rust	71.06% <67.39%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/meta/src/stream/stream_manager.rs	61.04% <67.39%> (+0.53%)	⬆️
src/storage/src/hummock/local_version_manager.rs	86.48% <0.00%> (+4.72%)	⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs	52.00% <0.00%> (+5.33%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more