Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split plan.proto and rename projection to project #2083

Merged
merged 8 commits into from
Apr 24, 2022

Conversation

TennyZhuang
Copy link
Collaborator

@TennyZhuang TennyZhuang commented Apr 24, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

  1. split "plan.proto" to "plan_common.proto" and "batch_plan.proto"
  2. rename batch::projection to batch::project
  3. remove some outdated commented codes.
  4. add FLUSH in TPC-H e2e test.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐮🍺

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang enabled auto-merge (squash) April 24, 2022 08:21
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🐮TM

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2083 (2845b3a) into main (b1d2349) will decrease coverage by 0.00%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
- Coverage   71.06%   71.05%   -0.01%     
==========================================
  Files         635      635              
  Lines       81619    81620       +1     
==========================================
- Hits        58000    57999       -1     
- Misses      23619    23621       +2     
Flag Coverage Δ
rust 71.05% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/execution/local_exchange.rs 67.03% <ø> (ø)
src/batch/src/executor/create_table.rs 52.54% <ø> (ø)
src/batch/src/executor/drop_stream.rs 0.00% <ø> (ø)
src/batch/src/executor/drop_table.rs 0.00% <ø> (ø)
src/batch/src/executor/generate_series.rs 66.26% <ø> (ø)
src/batch/src/executor/generic_exchange.rs 59.15% <ø> (ø)
src/batch/src/executor/join/hash_join.rs 85.57% <ø> (ø)
src/batch/src/executor/join/mod.rs 63.15% <ø> (ø)
src/batch/src/executor/join/nested_loop_join.rs 82.17% <ø> (ø)
src/batch/src/executor/join/sort_merge_join.rs 74.35% <ø> (ø)
... and 83 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang merged commit d57c97d into main Apr 24, 2022
@TennyZhuang TennyZhuang deleted the chore/unify-naming branch April 24, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants