Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): use HashKey in join key type #2087

Merged
merged 9 commits into from
Apr 24, 2022

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Apr 24, 2022

What's changed and what's your intention?

  • use HashKey in join key type
  • fix a bug when row contains a null datum.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1772

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2087 (2028475) into main (e5f1f8f) will decrease coverage by 0.02%.
The diff coverage is 46.84%.

@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
- Coverage   71.06%   71.04%   -0.03%     
==========================================
  Files         635      635              
  Lines       81619    81661      +42     
==========================================
+ Hits        58000    58012      +12     
- Misses      23619    23649      +30     
Flag Coverage Δ
rust 71.04% <46.84%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/mod.rs 70.67% <0.00%> (ø)
src/stream/src/executor/hash_join.rs 88.84% <34.56%> (-1.40%) ⬇️
src/stream/src/executor/managed_state/join/mod.rs 70.76% <79.16%> (+0.52%) ⬆️
src/common/src/collection/evictable.rs 73.58% <100.00%> (+1.58%) ⬆️
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️
src/prost/build.rs 100.00% <0.00%> (ø)
src/prost/src/lib.rs 96.29% <0.00%> (ø)
src/source/src/manager.rs 45.98% <0.00%> (ø)
src/batch/src/task/task_.rs 37.70% <0.00%> (ø)
... and 13 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: TennyZhuang <zty0826@gmail.com>
Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuhao-su yuhao-su enabled auto-merge (squash) April 24, 2022 09:46
@yuhao-su yuhao-su merged commit 6019ef1 into main Apr 24, 2022
@yuhao-su yuhao-su deleted the streaming_hash_null_situation branch April 24, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(stream): incorrect Row equal comparison in case null value exist.
3 participants