Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: replace new_with_ to with_ #2090

Merged
merged 2 commits into from
Apr 24, 2022
Merged

style: replace new_with_ to with_ #2090

merged 2 commits into from
Apr 24, 2022

Conversation

TennyZhuang
Copy link
Collaborator

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

https://doc.rust-lang.org/1.0.0/style/style/naming/README.html#general-conventions-[rfc-#430]

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@yuhao-su
Copy link
Contributor

LGTM

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@TennyZhuang TennyZhuang enabled auto-merge (squash) April 24, 2022 09:58
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2090 (937f520) into main (eacbd75) will decrease coverage by 0.00%.
The diff coverage is 83.82%.

@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   71.06%   71.06%   -0.01%     
==========================================
  Files         635      635              
  Lines       81620    81612       -8     
==========================================
- Hits        58001    57994       -7     
+ Misses      23619    23618       -1     
Flag Coverage Δ
rust 71.06% <83.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor2/filter.rs 76.59% <ø> (ø)
src/common/src/hash/key.rs 85.41% <0.00%> (ø)
src/storage/src/object/s3.rs 0.00% <0.00%> (ø)
src/storage/src/store_impl.rs 6.34% <0.00%> (+0.09%) ⬆️
src/common/src/types/mod.rs 64.47% <25.00%> (ø)
src/batch/src/executor/join/nested_loop_join.rs 82.17% <66.66%> (ø)
src/common/src/array/struct_array.rs 81.46% <80.00%> (ø)
src/common/src/array/list_array.rs 89.90% <85.71%> (ø)
src/batch/src/executor/join/sort_merge_join.rs 74.35% <100.00%> (ø)
src/common/src/array/bool_array.rs 95.51% <100.00%> (ø)
... and 21 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit 17b3d8a into main Apr 24, 2022
@TennyZhuang TennyZhuang deleted the style/no-new-with branch April 24, 2022 10:07
Copy link
Contributor

@nanderstabel nanderstabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants