refactor(metrics): use exponential_buckets #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2101 +/- ##
========================================
Coverage 70.82% 70.83%
========================================
Files 639 640 +1
Lines 81173 81485 +312
========================================
+ Hits 57494 57717 +223
- Misses 23679 23768 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sunt-ing
force-pushed
the
sunt_calibrate_params
branch
from
571b13f
to
9201963
Compare
|
Changed. @Little-Wallace |
| "Histogram of time spent from compacting shared buffer to remote storage.", | ||
| buckets | ||
| "Histogram of time spent from compacting shared buffer to remote storage", | ||
| exponential_buckets(0.0001, 2.0, 16).unwrap() // max 3s |
There was a problem hiding this comment.
3s is too small.
we can start since 1ms and we can observe 64s at most
| let opts = histogram_opts!( | ||
| "state_store_write_build_l0_sst_duration", | ||
| "Total time of batch_write_build_table that have been issued to state store", | ||
| buckets | ||
| exponential_buckets(0.001, 2.0, 16).unwrap() // max 32s |
There was a problem hiding this comment.
suggest start from 1ms because most
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
I refactored all Histogram buckets from
DEFAULT_BUCKETS+scaleormanually setting every bucketto exponential_buckets.Reasons:
DEFAULT_BUCKETS+scale, it's more flexible.manually setting every bucket, it's easier to tune or understand.Currently, the parameters used in this PR are set according to the previous parameters and my experience.
Checklist
Refer to a related PR or issue link (optional)
close #1006