Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proto): replace TableRefId to uint32 for HashJoin #2114

Merged
merged 1 commit into from Apr 25, 2022

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Apr 25, 2022

What's changed and what's your intention?

Previously I use TableRefId (wants to keep consistent with Materialize Executor), but it's too inconvenient to write code.

Given that we wil remove TableRefId after Java frontend removed, replace it now.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh
Copy link
Contributor

skyzh commented Apr 25, 2022

I'd propose replace all such occurrences to u32, if TableId is unique 🤣

@BowenXiao1999
Copy link
Contributor Author

BowenXiao1999 commented Apr 25, 2022

I'd propose replace all such occurrences to u32, if TableId is unique 🤣

Java is using TableRefId. So we have to change java code if do it now... But it indeed looks simple

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2114 (8395701) into main (8b6bd87) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   70.66%   70.69%   +0.03%     
==========================================
  Files         636      636              
  Lines       80752    80739      -13     
==========================================
+ Hits        57063    57080      +17     
+ Misses      23689    23659      -30     
Flag Coverage Δ
rust 70.69% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/meta/src/stream/fragmenter/graph/stream_graph.rs 63.65% <0.00%> (+1.09%) ⬆️
src/meta/src/stream/fragmenter/mod.rs 81.97% <0.00%> (+1.40%) ⬆️
src/stream/src/executor/hash_join.rs 81.60% <0.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/meta/src/barrier/mod.rs 69.00% <0.00%> (-0.34%) ⬇️
src/common/src/types/ordered_float.rs 24.30% <0.00%> (+0.19%) ⬆️
src/storage/src/hummock/local_version_manager.rs 86.48% <0.00%> (+4.72%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 52.00% <0.00%> (+5.33%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BowenXiao1999 BowenXiao1999 enabled auto-merge (squash) April 25, 2022 06:44
@BowenXiao1999 BowenXiao1999 enabled auto-merge (squash) April 25, 2022 06:44
@BowenXiao1999 BowenXiao1999 merged commit 5f5f36a into main Apr 25, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/fix-table-id-type branch April 25, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants