refactor(frontend): remove unused agg aliases #2115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
This
aliases
field inLogicalAgg
has always beenNone
(except in unit tests) and will not be used in the future (#1433).To reiterate:
aliases
will be user-facing and handled at bound sql level but not in plan nodes, whilefield
names are for internal debugging only and can follow whatever rules, possibly not matching aliases.Checklist
- [ ] I have written necessary docs and comments- [ ] I have added necessary unit tests and integration tests(Refactor does not break existing tests.)Refer to a related PR or issue link (optional)