Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): remove unused agg aliases #2115

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Apr 25, 2022

What's changed and what's your intention?

This aliases field in LogicalAgg has always been None (except in unit tests) and will not be used in the future (#1433).

To reiterate: aliases will be user-facing and handled at bound sql level but not in plan nodes, while field names are for internal debugging only and can follow whatever rules, possibly not matching aliases.

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests (Refactor does not break existing tests.)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2115 (3e35685) into main (8b6bd87) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2115      +/-   ##
==========================================
- Coverage   70.66%   70.64%   -0.02%     
==========================================
  Files         636      636              
  Lines       80752    80703      -49     
==========================================
- Hits        57063    57014      -49     
  Misses      23689    23689              
Flag Coverage Δ
rust 70.64% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.51% <100.00%> (-0.19%) ⬇️
.../frontend/src/optimizer/rule/unnest_agg_for_loj.rs 98.73% <100.00%> (ø)
src/frontend/src/planner/select.rs 89.43% <100.00%> (-0.08%) ⬇️
src/meta/src/barrier/mod.rs 69.00% <0.00%> (-0.34%) ⬇️
src/common/src/types/ordered_float.rs 24.30% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiangjinwu xiangjinwu marked this pull request as ready for review April 25, 2022 06:51
Copy link
Contributor

@likg227 likg227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangjinwu xiangjinwu merged commit b986bfa into main Apr 25, 2022
@xiangjinwu xiangjinwu deleted the rust-frontend-remove-agg-aliases branch April 25, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants