Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix level type error #2120

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix level type error #2120

merged 1 commit into from
Apr 25, 2022

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Apr 25, 2022

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What's changed and what's your intention?

Fix bug caused by #1994. It sets level type of target level by select level

Checklist

Refer to a related PR or issue link (optional)

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
Copy link
Contributor

@soundOfDestiny soundOfDestiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2120 (51c5275) into main (8976463) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main    #2120   +/-   ##
=======================================
  Coverage   70.82%   70.82%           
=======================================
  Files         640      640           
  Lines       81531    81534    +3     
=======================================
+ Hits        57744    57750    +6     
+ Misses      23787    23784    -3     
Flag Coverage Δ
rust 70.82% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/compaction.rs 80.97% <83.33%> (-0.12%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.02% <0.00%> (-0.27%) ⬇️
src/storage/src/hummock/compactor.rs 71.86% <0.00%> (+1.53%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Little-Wallace Little-Wallace merged commit 7500a39 into main Apr 25, 2022
@Little-Wallace Little-Wallace deleted the wallace/fix branch April 25, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants