fix(frontend): fix TopN in frontend to be compatible with current implementation #2129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
The current implementation of TopN in Java frontend & compute node assumes its PK should be exactly the same with sort keys, so the
PK of TopN = sort_key + input.pk
. This PR changes Rust frontend's behavior to be compatible with that.However, The PK of TopN should be the input's PK instead of
sort_key + input.pk
. To fix this, we need to change proto, compute nodes and rust & java frontend simultaneously. Let do this later.I've also added some e2e tests for order-by queries.
Checklist
Refer to a related PR or issue link (optional)