-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(array): add value_at_unchecked
for Array
#2136
Conversation
value_at_unchecked
for Arrayvalue_at_unchecked
for Array
value_at_unchecked
for Arrayvalue_at_unchecked
for Array
@TennyZhuang @skyzh PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, Thanks!
Codecov Report
@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
- Coverage 70.58% 70.57% -0.02%
==========================================
Files 650 650
Lines 82208 82266 +58
==========================================
+ Hits 58030 58060 +30
- Misses 24178 24206 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@TennyZhuang resolved, PTAL again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
An unchecked version of
value_at
is added to theArray
trait, and corresponding implementations are also added.Checklist
Refer to a related PR or issue link (optional)
close #1814