Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(array): add value_at_unchecked for Array #2136

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

ichn-hu
Copy link
Contributor

@ichn-hu ichn-hu commented Apr 26, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

An unchecked version of value_at is added to the Array trait, and corresponding implementations are also added.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

close #1814

@ichn-hu ichn-hu changed the title perf(WIP): add value_at_unchecked for Array [WIP] perf(array): add value_at_unchecked for Array Apr 26, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2022

CLA assistant check
All committers have signed the CLA.

@ichn-hu ichn-hu marked this pull request as ready for review April 27, 2022 10:29
@ichn-hu ichn-hu changed the title [WIP] perf(array): add value_at_unchecked for Array feat(array): add value_at_unchecked for Array Apr 27, 2022
@ichn-hu
Copy link
Contributor Author

ichn-hu commented Apr 27, 2022

@TennyZhuang @skyzh PTAL

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, Thanks!

src/common/src/array/data_chunk_iter.rs Outdated Show resolved Hide resolved
src/common/src/array/chrono_array.rs Outdated Show resolved Hide resolved
src/common/src/array/interval_array.rs Outdated Show resolved Hide resolved
src/common/src/array/primitive_array.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2136 (aacaf1b) into main (a366da9) will decrease coverage by 0.01%.
The diff coverage is 62.12%.

@@            Coverage Diff             @@
##             main    #2136      +/-   ##
==========================================
- Coverage   70.58%   70.57%   -0.02%     
==========================================
  Files         650      650              
  Lines       82208    82266      +58     
==========================================
+ Hits        58030    58060      +30     
- Misses      24178    24206      +28     
Flag Coverage Δ
rust 70.57% <62.12%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/chrono_array.rs 78.94% <0.00%> (-3.09%) ⬇️
src/common/src/array/decimal_array.rs 90.61% <0.00%> (-2.18%) ⬇️
src/common/src/array/list_array.rs 88.88% <0.00%> (-1.02%) ⬇️
src/common/src/array/struct_array.rs 80.43% <0.00%> (-1.27%) ⬇️
src/common/src/array/bool_array.rs 92.54% <50.00%> (-2.97%) ⬇️
src/common/src/array/mod.rs 70.95% <85.71%> (+0.28%) ⬆️
src/common/src/array/interval_array.rs 63.24% <88.88%> (+2.13%) ⬆️
src/common/src/array/data_chunk_iter.rs 85.30% <100.00%> (+0.26%) ⬆️
src/common/src/array/primitive_array.rs 90.81% <100.00%> (+0.25%) ⬆️
src/common/src/array/utf8_array.rs 93.47% <100.00%> (+0.16%) ⬆️
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Apr 28, 2022

@TennyZhuang resolved, PTAL again.

@TennyZhuang
Copy link
Collaborator

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@TennyZhuang TennyZhuang merged commit 46160cc into risingwavelabs:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array: implement value_at_unchecked
4 participants