Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused api in cluster manager #2139

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Apr 26, 2022

What's changed and what's your intention?

  • Removed deactivate_worker_node in ClusterManager.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2139 (67ebf1a) into main (8191749) will increase coverage by 0.06%.
The diff coverage is 94.66%.

@@            Coverage Diff             @@
##             main    #2139      +/-   ##
==========================================
+ Coverage   70.53%   70.59%   +0.06%     
==========================================
  Files         645      645              
  Lines       81657    81673      +16     
==========================================
+ Hits        57595    57659      +64     
+ Misses      24062    24014      -48     
Flag Coverage Δ
rust 70.59% <94.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/session.rs 51.03% <ø> (ø)
src/meta/src/barrier/mod.rs 69.00% <ø> (ø)
src/meta/src/rpc/service/ddl_service.rs 0.00% <ø> (ø)
src/meta/src/cluster/mod.rs 59.65% <90.00%> (+2.77%) ⬆️
src/frontend/src/scheduler/worker_node_manager.rs 69.86% <100.00%> (+51.44%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.02% <0.00%> (-0.27%) ⬇️
src/storage/src/hummock/local_version_manager.rs 91.05% <0.00%> (+2.03%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 49.36% <0.00%> (+5.06%) ⬆️
src/common/src/util/addr.rs 95.69% <0.00%> (+6.45%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012
Copy link
Contributor

get_cluster_core_guard is used for snapshot consistency when synced to frontend. Suggest to keep it. Cc @HuaHuaY

@neverchanje neverchanje merged commit be76011 into main Apr 26, 2022
@neverchanje neverchanje deleted the wt-refine-struct-field branch April 26, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants