Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): remove DataChunkRef #2143

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

TennyZhuang
Copy link
Collaborator

Signed-off-by: TennyZhuang zty0826@gmail.com

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Columns inside DataChunk are already wrapped with Arc, so it's useless to use Arc.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2143 (c0d8b8c) into main (10f0d2e) will increase coverage by 0.03%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
+ Coverage   70.54%   70.57%   +0.03%     
==========================================
  Files         645      645              
  Lines       81703    81720      +17     
==========================================
+ Hits        57637    57676      +39     
+ Misses      24066    24044      -22     
Flag Coverage Δ
rust 70.57% <90.47%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/array/mod.rs 70.67% <ø> (ø)
src/batch/src/executor/order_by.rs 82.76% <33.33%> (ø)
src/batch/src/executor/merge_sort_exchange.rs 75.34% <100.00%> (ø)
src/batch/src/executor/test_utils.rs 91.66% <100.00%> (ø)
src/batch/src/executor2/limit.rs 91.70% <100.00%> (+0.03%) ⬆️
src/batch/src/executor2/top_n.rs 80.29% <100.00%> (ø)
src/common/src/array/data_chunk.rs 89.74% <100.00%> (ø)
src/common/src/util/sort_util.rs 82.75% <100.00%> (ø)
src/meta/src/hummock/mock_hummock_meta_client.rs 44.30% <0.00%> (-5.07%) ⬇️
src/storage/src/hummock/local_version_manager.rs 89.02% <0.00%> (-2.04%) ⬇️
... and 6 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyZhuang TennyZhuang merged commit 918e661 into main Apr 26, 2022
@TennyZhuang TennyZhuang deleted the refactor/remove-data-chunk-ref branch April 26, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants