-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): add delta join solver #2144
Conversation
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
4f7fef3
to
9919ffd
Compare
Codecov Report
@@ Coverage Diff @@
## main #2144 +/- ##
==========================================
+ Coverage 70.51% 70.60% +0.09%
==========================================
Files 645 649 +4
Lines 81785 82164 +379
==========================================
+ Hits 57668 58010 +342
- Misses 24117 24154 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Alex Chi <iskyzh@gmail.com>
bb740c7
to
c5d787a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LSTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM. if we can rename the join_solver
as delta_join_solver
?
+1. I've got a lot of rename requests recently, and I'd like to do this in one PR later. |
Just come up with a new arrange strategy: |
LGTM. |
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Fixed several typos in this PR, and made arrange strategies to be left-most by default. After some discussion with @st1page, we decide to minimize the data on stream in all cases. |
Signed-off-by: Alex Chi iskyzh@gmail.com
What's changed and what's your intention?
The solver generates the lookup plans by controlling two parameters
StreamStrategy::LeftThisEpoch
orArrangeStrategy::LeftFirst
and based on join order generated by optimizer.Checklist
Refer to a related PR or issue link (optional)
ref #1962
close #2147