feat(storage): enable metric collector in compactor node. #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 753 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 749 | 2 | 2 | 0 |
Click to see the invalid file list
- src/common/src/service/metrics_manager.rs
- src/common/src/service/mod.rs
zwang28
force-pushed
the
wangzheng/enable_compactor_metrics
branch
from
8a4cc20
to
7de217b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2160 +/- ##
=======================================
Coverage 70.51% 70.51%
=======================================
Files 645 646 +1
Lines 81782 81800 +18
=======================================
+ Hits 57669 57685 +16
- Misses 24113 24115 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
zwang28
force-pushed
the
wangzheng/enable_compactor_metrics
branch
from
7de217b
to
bc764bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Enable prometheus collector in compactor server.
MetricsManageris moved from compute crate to common crate.Checklist
Refer to a related PR or issue link (optional)