Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): introduce BatchHopWindow in frontend #2170

Merged
merged 6 commits into from
Apr 27, 2022

Conversation

TennyZhuang
Copy link
Collaborator

Signed-off-by: TennyZhuang zty0826@gmail.com

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

src/frontend/src/optimizer/plan_node/batch_hop_window.rs Outdated Show resolved Hide resolved
TennyZhuang and others added 4 commits April 27, 2022 15:37
Co-authored-by: stonepage <40830455+st1page@users.noreply.github.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2170 (0e10668) into main (a91ef15) will increase coverage by 0.00%.
The diff coverage is 74.64%.

@@           Coverage Diff           @@
##             main    #2170   +/-   ##
=======================================
  Coverage   70.56%   70.56%           
=======================================
  Files         649      650    +1     
  Lines       82105    82166   +61     
=======================================
+ Hits        57938    57984   +46     
- Misses      24167    24182   +15     
Flag Coverage Δ
rust 70.56% <74.64%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 60.46% <0.00%> (-2.19%) ⬇️
src/frontend/src/optimizer/plan_node/mod.rs 97.11% <ø> (ø)
...ontend/src/optimizer/plan_node/batch_hop_window.rs 71.69% <71.69%> (ø)
...tend/src/optimizer/plan_node/logical_hop_window.rs 99.25% <100.00%> (+4.02%) ⬆️
...ntend/src/optimizer/plan_node/stream_hop_window.rs 74.19% <100.00%> (-2.95%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.02% <0.00%> (-0.27%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit f3199ed into main Apr 27, 2022
@TennyZhuang TennyZhuang deleted the feat/frontend-batch-hop-window branch April 27, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants