Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): refactor some unit tests by relational interfaces #2177

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Apr 27, 2022

What's changed and what's your intention?

As some relational interfaces has been implemented, ManageMViewState can be replaced by StateTable. This PR replaced ManageMViewState with StateTable in some unit tests.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2177 (7ec85ec) into main (cba093f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   70.57%   70.61%   +0.03%     
==========================================
  Files         650      650              
  Lines       82177    82287     +110     
==========================================
+ Hits        57997    58106     +109     
- Misses      24180    24181       +1     
Flag Coverage Δ
rust 70.61% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/table/state_table.rs 90.48% <100.00%> (+0.12%) ⬆️
src/stream/src/executor_v2/mview/materialize.rs 91.33% <100.00%> (+0.20%) ⬆️
.../stream/src/executor_v2/mview/table_state_tests.rs 97.01% <100.00%> (+0.63%) ⬆️
src/stream/src/executor_v2/mview/test_utils.rs 100.00% <100.00%> (ø)
src/common/src/types/ordered_float.rs 24.10% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcy-fdu wcy-fdu merged commit 9bce175 into main Apr 28, 2022
@wcy-fdu wcy-fdu deleted the wcy_refactor_relational_ut branch April 28, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants