Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): extract table id from full key #2178

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

soundOfDestiny
Copy link
Contributor

What's changed and what's your intention?

extract table id from full key

Checklist

  • I have written necessary docs and comments

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2178 (2ac94a9) into main (a9ffebc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2178      +/-   ##
==========================================
- Coverage   70.59%   70.58%   -0.01%     
==========================================
  Files         650      650              
  Lines       82204    82208       +4     
==========================================
  Hits        58030    58030              
- Misses      24174    24178       +4     
Flag Coverage Δ
rust 70.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/hummock_sdk/src/key.rs 85.71% <0.00%> (-3.40%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But if it's better to place encode_table_id_to_key and get_table_id together.

@soundOfDestiny soundOfDestiny merged commit a366da9 into main Apr 27, 2022
@soundOfDestiny soundOfDestiny deleted the zl_tableid branch April 27, 2022 14:34
@soundOfDestiny
Copy link
Contributor Author

LGTM. But if it's better to place encode_table_id_to_key and get_table_id together.

encode_table_id_to_key is in src/storage/src/keyspace.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants